fix(close-button): pass slot="close" prop to RAC Button component#181
Open
amitbeck wants to merge 1 commit into
Open
fix(close-button): pass slot="close" prop to RAC Button component#181amitbeck wants to merge 1 commit into
slot="close" prop to RAC Button component#181amitbeck wants to merge 1 commit into
Conversation
A button with a `slot="close"` will act as a close button and close RAC modals and overlays https://react-aria.adobe.com/Modal#api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A button with a
slot="close"will act as a close button and close RAC modals and overlayshttps://react-aria.adobe.com/Modal#api
Related issues
Closes #
Type of change
Testing
Testing checklist
Manual testing steps
Screenshots/Videos
Before
After
Code quality checklist
@/components/...)📚 Documentation
Breaking changes
Migration guide
Additional context